[PATCH] drm/amdgpu/userq: convert comma to semicolon

[PATCH] drm/amdgpu/userq: convert comma to semicolon

[Chen Ni]

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
index 781896c9fd26..6daec964ca5e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
@@ -961,13 +961,13 @@ int amdgpu_userq_wait_ioctl(struct drm_device *dev, void *data,
 	}
 
 	num_read_bo_handles = wait_info->num_bo_read_handles;
-	ptr = u64_to_user_ptr(wait_info->bo_read_handles),
+	ptr = u64_to_user_ptr(wait_info->bo_read_handles);
 	r = drm_gem_objects_lookup(filp, ptr, num_read_bo_handles, &gobj_read);
 	if (r)
 		goto free_timeline_points;
 
 	num_write_bo_handles = wait_info->num_bo_write_handles;
-	ptr = u64_to_user_ptr(wait_info->bo_write_handles),
+	ptr = u64_to_user_ptr(wait_info->bo_write_handles);
 	r = drm_gem_objects_lookup(filp, ptr, num_write_bo_handles,
 				   &gobj_write);
 	if (r)
-- 
2.25.1

Claude review: drm/amdgpu/userq: convert comma to semicolon

[Claude Code Review Bot]

Overall Series Review

Subject: drm/amdgpu/userq: convert comma to semicolon
Author: Chen Ni <nichen@iscas.ac.cn>
Patches: 1
Reviewed: 2026-03-22T03:50:49.911217

---

This is a single trivial cleanup patch that replaces comma operators (`,`) with semicolons (`;`) at the end of two assignment statements in `amdgpu_userq_fence.c`. The change is cosmetically correct — using a comma here is legal C but misleading, as the comma operator's result is discarded. There is no functional change since these are standalone expression statements, not part of a `for`-loop header, macro, or multi-expression context where a comma would matter.

The patch is correct and harmless, but extremely low value.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/amdgpu/userq: convert comma to semicolon

[Claude Code Review Bot]

Patch Review

**Assessment: Low-priority cleanup, technically correct**

The two changed lines (lines 964 and 971 of the original file) both have the pattern:

```c
ptr = u64_to_user_ptr(wait_info->bo_read_handles),
```

changed to:

```c
ptr = u64_to_user_ptr(wait_info->bo_read_handles);
```

The trailing `,` makes the assignment part of a comma expression, but since the next statement is on a separate line and the comma's result (the value of `ptr`) is discarded, there is no behavioral difference. The fix is correct — semicolons are the intended statement terminators here, and the commas were likely typos (possibly from copy-paste of an initializer list or similar).

**Minor observations:**
- The commit message is fine and accurately describes the change as having no functional impact.
- "Compile tested only" is acceptable for this type of change, though runtime testing would always be preferred for driver code.
- The "Found by inspection" note is honest but also a hallmark of low-value automated/mechanical cleanup patches. Maintainers may or may not care to take these.

**Verdict:** Correct but trivial. No objections to merging, but also no urgency.

---
Generated by Claude Code Patch Reviewer