From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu/userq: convert comma to semicolon Date: Sun, 22 Mar 2026 03:50:50 +1000 Message-ID: In-Reply-To: <20260320083247.428482-1-nichen@iscas.ac.cn> References: <20260320083247.428482-1-nichen@iscas.ac.cn> <20260320083247.428482-1-nichen@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Assessment: Low-priority cleanup, technically correct** The two changed lines (lines 964 and 971 of the original file) both have th= e pattern: ```c ptr =3D u64_to_user_ptr(wait_info->bo_read_handles), ``` changed to: ```c ptr =3D u64_to_user_ptr(wait_info->bo_read_handles); ``` The trailing `,` makes the assignment part of a comma expression, but since= the next statement is on a separate line and the comma's result (the value= of `ptr`) is discarded, there is no behavioral difference. The fix is corr= ect =E2=80=94 semicolons are the intended statement terminators here, and t= he commas were likely typos (possibly from copy-paste of an initializer lis= t or similar). **Minor observations:** - The commit message is fine and accurately describes the change as having = no functional impact. - "Compile tested only" is acceptable for this type of change, though runti= me testing would always be preferred for driver code. - The "Found by inspection" note is honest but also a hallmark of low-value= automated/mechanical cleanup patches. Maintainers may or may not care to t= ake these. **Verdict:** Correct but trivial. No objections to merging, but also no urg= ency. --- Generated by Claude Code Patch Reviewer