[PATCH V3] MAINTAINERS: Update GPU driver maintainer information

[PATCH V3] MAINTAINERS: Update GPU driver maintainer information

[Jianmin Lv]

I and Qianhai are GPU R&D engineers at Loongson, specializing
in kernel driver development. We understand that the current
Loongson GPU driver lacks dedicated maintenance resources
because of some reasons.

As Loongson GPU driver developers, we have both the capability
and the responsibility to continuously maintain the Loongson
GPU driver, ensuring minimal impact on its users. After internal
discussions, our team has decided to recommend me and Qianhai
to take over the maintenance responsibilities, and recommend
Huacai, Mingcong and Ruoyao to help to review.

And We'll continue to maintain it for current supported chips
and drive future updates according to chip support plan.

Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>

diff --git a/MAINTAINERS b/MAINTAINERS
index 96ea84948d76..eccb8273cd3a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8626,8 +8626,14 @@ F:	drivers/gpu/drm/lima/
 F:	include/uapi/drm/lima_drm.h
 
 DRM DRIVERS FOR LOONGSON
+M:	Jianmin Lv <lvjianmin@loongson.cn>
+M:	Qianhai Wu <wuqianhai@loongson.cn>
+R:	Huacai Chen <chenhuacai@kernel.org>
+R:	Mingcong Bai <jeffbai@aosc.io>
+R:	Xi Ruoyao <xry111@xry111.site>
+R:	Icenowy Zheng <zhengxingda@iscas.ac.cn>
 L:	dri-devel@lists.freedesktop.org
-S:	Orphan
+S:	Maintained
 T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
 F:	drivers/gpu/drm/loongson/
 
-- 
2.20.1

Re: [PATCH V3] MAINTAINERS: Update GPU driver maintainer information

[Thomas Zimmermann]

Am 20.03.26 um 11:10 schrieb Jianmin Lv:
> I and Qianhai are GPU R&D engineers at Loongson, specializing
> in kernel driver development. We understand that the current
> Loongson GPU driver lacks dedicated maintenance resources
> because of some reasons.
>
> As Loongson GPU driver developers, we have both the capability
> and the responsibility to continuously maintain the Loongson
> GPU driver, ensuring minimal impact on its users. After internal
> discussions, our team has decided to recommend me and Qianhai
> to take over the maintenance responsibilities, and recommend
> Huacai, Mingcong and Ruoyao to help to review.
>
> And We'll continue to maintain it for current supported chips
> and drive future updates according to chip support plan.
>
> Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 96ea84948d76..eccb8273cd3a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8626,8 +8626,14 @@ F:	drivers/gpu/drm/lima/
>   F:	include/uapi/drm/lima_drm.h
>   
>   DRM DRIVERS FOR LOONGSON
> +M:	Jianmin Lv <lvjianmin@loongson.cn>
> +M:	Qianhai Wu <wuqianhai@loongson.cn>
> +R:	Huacai Chen <chenhuacai@kernel.org>
> +R:	Mingcong Bai <jeffbai@aosc.io>
> +R:	Xi Ruoyao <xry111@xry111.site>
> +R:	Icenowy Zheng <zhengxingda@iscas.ac.cn>
>   L:	dri-devel@lists.freedesktop.org
> -S:	Orphan
> +S:	Maintained
>   T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
>   F:	drivers/gpu/drm/loongson/
>   

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)

Claude review: MAINTAINERS: Update GPU driver maintainer information

[Claude Code Review Bot]

Patch Review

**Apply failure:** The patch context expects `S: Orphan` and no `M:` line, but the current drm-next tree has:
```
M:	Sui Jingfeng <suijingfeng@loongson.cn>
...
S:	Supported
```
The patch needs to be rebased against the current tree.

**Substantive concerns:**

1. **No removal of previous maintainer:** The patch silently removes Sui Jingfeng without any explanation in the commit message. The cover letter says the driver "lacks dedicated maintenance resources because of some reasons" — this is vague and does not explain the transition from Sui Jingfeng's maintainership. A maintainer change should clearly address the previous maintainer's status, ideally with their Acked-by or at least an explanation.

2. **Missing Acked-by / Reviewed-by tags:** For a MAINTAINERS change of this nature (taking over an entry), it would be appropriate to have:
   - An Ack from the previous maintainer (Sui Jingfeng), or an explanation of why this isn't possible.
   - Acks from the newly-listed reviewers (Huacai Chen, Mingcong Bai, Xi Ruoyao, Icenowy Zheng) confirming they agree to be listed.

3. **Status downgrade:** The current tree has `S: Supported`, and this patch changes it to `S: Maintained`. While this is a step up from the "Orphan" the patch assumes, relative to the actual current state this is a downgrade. The difference matters: "Supported" implies a higher level of commitment than "Maintained" per the MAINTAINERS file conventions. This should be discussed.

4. **Commit message quality:** The commit message body reads more like a cover letter than a proper changelog. Phrases like "because of some reasons" are too vague for a permanent record. The message should concisely state what changed and why.

5. **The diff itself is mechanically correct** — the MAINTAINERS format (M/R/L/S/T/F fields in proper order) is followed correctly, and the added entries use the standard format.

**Recommendation:** The patch needs a rebase onto current drm-next, clarification of the relationship with the previous maintainer (Sui Jingfeng), Acked-by tags from the listed reviewers, and a cleaner commit message.

---
Generated by Claude Code Patch Reviewer

Claude review: MAINTAINERS: Update GPU driver maintainer information

[Claude Code Review Bot]

Overall Series Review

Subject: MAINTAINERS: Update GPU driver maintainer information
Author: Jianmin Lv <lvjianmin@loongson.cn>
Patches: 2
Reviewed: 2026-03-22T03:49:49.559282

---

This is a single-patch series updating the MAINTAINERS entry for the Loongson DRM GPU driver. The patch adds new maintainers (Jianmin Lv and Qianhai Wu) and reviewers (Huacai Chen, Mingcong Bai, Xi Ruoyao, Icenowy Zheng), and changes the status from "Orphan" to "Maintained."

The patch **does not apply cleanly** because it was based on an older tree where the status was "Orphan" and there was no maintainer listed. The current drm-next tree (line 8635) shows `Sui Jingfeng <suijingfeng@loongson.cn>` as maintainer with status "Supported" — not "Orphan." This is a significant context mismatch that indicates the patch was developed against a stale base.

---
Generated by Claude Code Patch Reviewer