public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel: Add Novatek NT35532 LCD DSI
Date: Sun, 22 Mar 2026 03:00:52 +1000	[thread overview]
Message-ID: <review-patch1-20260321-rimob-new-features-v3-1-d4b8ee867de7@protonmail.com> (raw)
In-Reply-To: <20260321-rimob-new-features-v3-1-d4b8ee867de7@protonmail.com>

Patch Review

The binding looks reasonable and follows existing panel binding patterns.

**Minor issue: `vddam-supply` defined but never used.**
The binding defines:
```yaml
  vddam-supply:
    description: power supply for MIPI interface
```
But the panel driver (patch 2) does not request a `vddam` regulator - only `vci`, `vddi`, `avee`, and `avdd`. And the DTS (patch 3) never specifies `vddam-supply`. If this supply exists in the datasheet but isn't used on the only known board, it's fine to document it in the binding. But verify it's actually a real supply from the NT35532 datasheet - no other kernel driver references `vddam`.

**Nit: compatible is `const`, not a list.** This means only bare NT35532 panels are supported, with no board-specific compatibles. This is fine for a simple panel, but if different boards use different init sequences, a pattern like `"vendor,board-panel", "novatek,nt35532"` might be more future-proof. Not a blocker.

The MAINTAINERS entry is correct but is missing the driver file entry (added in patch 2, which is the right split).

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-21 17:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-21 16:23 [PATCH v3 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-21 16:23 ` [PATCH v3 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI Cristian Cozzolino via B4 Relay
2026-03-21 16:45   ` Dmitry Baryshkov
2026-03-21 17:00   ` Claude Code Review Bot [this message]
2026-03-21 16:23 ` [PATCH v3 2/6] drm/panel: Add driver for Novatek NT35532 Cristian Cozzolino via B4 Relay
2026-03-21 17:00   ` Claude review: " Claude Code Review Bot
2026-03-21 16:23 ` [PATCH v3 3/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU Cristian Cozzolino via B4 Relay
2026-03-21 17:00   ` Claude review: " Claude Code Review Bot
2026-03-21 16:23 ` [PATCH v3 4/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable WiFi/Bluetooth Cristian Cozzolino via B4 Relay
2026-03-21 17:00   ` Claude review: " Claude Code Review Bot
2026-03-21 16:23 ` [PATCH v3 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen Cristian Cozzolino via B4 Relay
2026-03-21 17:00   ` Claude review: " Claude Code Review Bot
2026-03-21 16:23 ` [PATCH v3 6/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Cristian Cozzolino via B4 Relay
2026-03-21 17:00   ` Claude review: " Claude Code Review Bot
2026-03-21 17:00 ` Claude review: Enable new features for flipkart-rimob Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-18 22:28 [PATCH v2 0/6] " Cristian Cozzolino via B4 Relay
2026-03-18 22:28 ` [PATCH v2 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI Cristian Cozzolino via B4 Relay
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 [PATCH 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-08 15:52 ` [PATCH 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI Cristian Cozzolino via B4 Relay
2026-03-08 21:46   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260321-rimob-new-features-v3-1-d4b8ee867de7@protonmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox