From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Change dither policy for 10 bpc output back to dithering
Date: Sun, 22 Mar 2026 03:13:39 +1000 [thread overview]
Message-ID: <review-patch1-20260321052033.23472-1-mario.kleiner.de@gmail.com> (raw)
In-Reply-To: <20260321052033.23472-1-mario.kleiner.de@gmail.com>
Patch Review
**Correctness:** The change at `dc_resource.c:5057-5058` from `DITHER_OPTION_TRUN10` to `DITHER_OPTION_SPATIAL10` is correct. Looking at the downstream handling:
- `DITHER_OPTION_SPATIAL10` is handled at lines 5125-5133, which sets `SPATIAL_DITHER_ENABLED = 1`, `SPATIAL_DITHER_DEPTH = 2`, along with `HIGHPASS_RANDOM` and conditional `RGB_RANDOM`. This is the proper spatial dithering path.
- The old `DITHER_OPTION_TRUN10` at lines 5076-5086 only set truncation with `TRUNCATE_MODE = 1` (rounding), losing the precision benefit of spatial dithering.
- The pattern is now consistent with `COLOR_DEPTH_666 → DITHER_OPTION_SPATIAL6` and `COLOR_DEPTH_888 → DITHER_OPTION_SPATIAL8`.
**Commit message quality:** Excellent. The author provides thorough technical justification for the revert, explains the real-world impact (scientific applications, fp16/rgba16 framebuffers, the 8 bpc vs 10 bpc absurdity), names specific software that benefits (Mesa 25.3, GNOME 50 mutter), and documents actual hardware testing (Polaris DCE 11.2 and Raven Ridge DCN 1.0 with photometer measurements).
**Minor observations:**
- The `Fixes:` tag and `Cc: stable` are appropriate since this is restoring a regression in precision for users of > 10 bpc pipelines.
- The only concern would be whether there exists some hardware where spatial dithering to 10 bpc causes visual artifacts — but the author explicitly tested on two different generations (Polaris and Raven Ridge) with no issues, and the original commit that introduced truncation did not cite any such hardware problems either.
**No issues found.** This is a clean, well-justified fix.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-21 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 5:20 [PATCH] drm/amd/display: Change dither policy for 10 bpc output back to dithering Mario Kleiner
2026-03-21 17:13 ` Claude review: " Claude Code Review Bot
2026-03-21 17:13 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260321052033.23472-1-mario.kleiner.de@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox