[PATCH] drm/amd/display: update outdated comments for renamed vblank_control_worker()

[PATCH] drm/amd/display: update outdated comments for renamed vblank_control_worker()

[Kexin Sun]

The function vblank_control_worker() was renamed
to amdgpu_dm_crtc_vblank_control_worker() by commit
6ce4f9ee25ff ("drm/amd/display: Add prefix to amdgpu crtc
functions").  Update the two stale references in
amdgpu_dm.c.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index b3d6f2cd8ab6..c2b7b31b0d29 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -9894,7 +9894,8 @@ static void amdgpu_dm_enable_self_refresh(struct amdgpu_crtc *acrtc_attach,
 		 * a vblank event disable request to enable PSR/RP. PSR SU/RP
 		 * can be enabled immediately once OS demonstrates an
 		 * adequate number of fast atomic commits to notify KMD
-		 * of update events. See `vblank_control_worker()`.
+		 * of update events.
+		 * See `amdgpu_dm_crtc_vblank_control_worker()`.
 		 */
 		if (!vrr_active &&
 		    acrtc_attach->dm_irq_params.allow_sr_entry &&
@@ -10062,8 +10063,9 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_state *state,
 			/*
 			 * If the dirty regions changed, PSR-SU need to be disabled temporarily
 			 * and enabled it again after dirty regions are stable to avoid video glitch.
-			 * PSR-SU will be enabled in vblank_control_worker() if user pause the video
-			 * during the PSR-SU was disabled.
+			 * PSR-SU will be enabled in
+			 * amdgpu_dm_crtc_vblank_control_worker() if user
+			 * pause the video during the PSR-SU was disabled.
 			 */
 			if (acrtc_state->stream->link->psr_settings.psr_version >= DC_PSR_VERSION_SU_1 &&
 			    acrtc_attach->dm_irq_params.allow_sr_entry &&
-- 
2.25.1

Claude review: drm/amd/display: update outdated comments for renamed vblank_control_worker()

[Claude Code Review Bot]

Overall Series Review

Subject: drm/amd/display: update outdated comments for renamed vblank_control_worker()
Author: Kexin Sun <kexinsun@smail.nju.edu.cn>
Patches: 1
Reviewed: 2026-03-22T03:07:22.157312

---

This is a single-patch series that updates two stale comment references to `vblank_control_worker()` in `amdgpu_dm.c`, replacing them with the current function name `amdgpu_dm_crtc_vblank_control_worker()` after it was renamed in commit 6ce4f9ee25ff.

The change is trivial, correct, and improves code maintainability by keeping comments in sync with actual function names. No functional changes.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/amd/display: update outdated comments for renamed vblank_control_worker()

[Claude Code Review Bot]

Patch Review

**Correctness**: The patch is correct. The function `amdgpu_dm_crtc_vblank_control_worker()` is defined at `amdgpu_dm_crtc.c:246`, confirming the rename happened and the new name in the comments is accurate.

**Minor nits**:

1. The `Assisted-by: unnamed:deepseek-v3.2 coccinelle` tag is non-standard. Typically for tool-assisted changes, the tag format would be something like `Reported-by:` or just mentioned in the commit message body. The kernel community has discussed `Assisted-by:` but it is not yet a widely recognized trailer. The maintainer may ask for this to be adjusted.

2. The line wrapping in the second hunk is slightly awkward:
   ```
   +			 * PSR-SU will be enabled in
   +			 * amdgpu_dm_crtc_vblank_control_worker() if user
   +			 * pause the video during the PSR-SU was disabled.
   ```
   This could read more naturally as a single reflow, but given the 80-column constraint and the long function name, it's acceptable.

3. Pre-existing grammar issue (not introduced by this patch): "if user pause the video during the PSR-SU was disabled" reads awkwardly — it should be "if the user pauses the video while PSR-SU is disabled." Since the patch is touching these lines anyway, it would be a nice cleanup to fix the grammar, but this is optional.

**Verdict**: The patch is straightforward and correct. Acceptable as-is, with optional grammar cleanup.

---
Generated by Claude Code Patch Reviewer