public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: update outdated comment for renamed amdgpu_fence_driver_init()
@ 2026-03-21 10:57 Kexin Sun
  2026-03-21 17:05 ` Claude review: " Claude Code Review Bot
  2026-03-21 17:05 ` Claude Code Review Bot
  0 siblings, 2 replies; 3+ messages in thread
From: Kexin Sun @ 2026-03-21 10:57 UTC (permalink / raw)
  To: alexander.deucher, christian.koenig, airlied, simona,
	timur.kristof, tglx, mingo, amd-gfx, dri-devel, linux-kernel
  Cc: julia.lawall, xutong.ma, kexinsun, yunbolyu, ratnadiraw

The function amdgpu_fence_driver_init() was renamed to
amdgpu_fence_driver_sw_init() by commit 067f44c8b459
("drm/amdgpu: avoid over-handle of fence driver fini in s3
test (v2)").  Update the stale reference in the
amdgpu_fence_driver_init_ring() kdoc.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
index 1054d66c54fa..37534f66c755 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
@@ -458,7 +458,7 @@ int amdgpu_fence_driver_start_ring(struct amdgpu_ring *ring,
  * @ring: ring to init the fence driver on
  *
  * Init the fence driver for the requested ring (all asics).
- * Helper function for amdgpu_fence_driver_init().
+ * Helper function for amdgpu_fence_driver_sw_init().
  */
 int amdgpu_fence_driver_init_ring(struct amdgpu_ring *ring)
 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Claude review: drm/amdgpu: update outdated comment for renamed amdgpu_fence_driver_init()
  2026-03-21 10:57 [PATCH] drm/amdgpu: update outdated comment for renamed amdgpu_fence_driver_init() Kexin Sun
@ 2026-03-21 17:05 ` Claude Code Review Bot
  2026-03-21 17:05 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-21 17:05 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm/amdgpu: update outdated comment for renamed amdgpu_fence_driver_init()
Author: Kexin Sun <kexinsun@smail.nju.edu.cn>
Patches: 1
Reviewed: 2026-03-22T03:05:09.512711

---

This is a single-patch series that makes a trivial but correct comment fix. The function `amdgpu_fence_driver_init()` was previously renamed to `amdgpu_fence_driver_sw_init()`, and a kdoc comment still referenced the old name. The fix is straightforward and accurate.

**Verdict: Patch looks good.**

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Claude review: drm/amdgpu: update outdated comment for renamed amdgpu_fence_driver_init()
  2026-03-21 10:57 [PATCH] drm/amdgpu: update outdated comment for renamed amdgpu_fence_driver_init() Kexin Sun
  2026-03-21 17:05 ` Claude review: " Claude Code Review Bot
@ 2026-03-21 17:05 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-21 17:05 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Correctness:** The change is correct. The function `amdgpu_fence_driver_sw_init()` exists at `amdgpu_fence.c:484`, confirming the rename happened. The kdoc for `amdgpu_fence_driver_init_ring()` was referencing the stale name `amdgpu_fence_driver_init()`.

```diff
- * Helper function for amdgpu_fence_driver_init().
+ * Helper function for amdgpu_fence_driver_sw_init().
```

**Minor nit on the commit message:** The `Assisted-by: unnamed:deepseek-v3.2 coccinelle` tag is non-standard. The kernel community has been discussing AI-assisted contributions, but this tag format isn't established. The maintainer may want to adjust this or ask for it to be dropped/reformatted.

**Overall:** Trivially correct comment-only fix. No functional impact. Fine to merge as-is (modulo the tag discussion).

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-21 17:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-21 10:57 [PATCH] drm/amdgpu: update outdated comment for renamed amdgpu_fence_driver_init() Kexin Sun
2026-03-21 17:05 ` Claude review: " Claude Code Review Bot
2026-03-21 17:05 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox