From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/sysfs: update outdated comment for renamed drm_sysfs_connector_status_event()
Date: Sun, 22 Mar 2026 03:06:17 +1000 [thread overview]
Message-ID: <review-patch1-20260321105739.6472-1-kexinsun@smail.nju.edu.cn> (raw)
In-Reply-To: <20260321105739.6472-1-kexinsun@smail.nju.edu.cn>
Patch Review
**Assessment: Correct and complete.**
The patch makes two changes in the comment block above `drm_sysfs_hotplug_event()`:
1. Updates the function reference:
```
- * Any new uapi should be using the drm_sysfs_connector_status_event()
+ * Any new uapi should be using the drm_sysfs_connector_property_event()
```
2. Updates the description to match:
```
- * for uevents on connector status change.
+ * for uevents on connector property change.
```
Both changes are accurate — the function is indeed named `drm_sysfs_connector_property_event()` in the current tree (line 490 of `drm_sysfs.c`), and the rename commit `0cf8d292ba5e` is correctly cited.
**Minor nit:** The `Assisted-by: unnamed:deepseek-v3.2 coccinelle` tag is non-standard. The kernel community typically uses tags like `Assisted-by: <tool description>` without mixing tool names with semicolons in this way. However, since this is a trivial comment fix found via tooling, this is unlikely to be a blocker — a maintainer may just ask for the tag to be cleaned up or dropped.
**No technical concerns.** The patch is minimal, correct, and well-described in its commit message.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-21 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 10:57 [PATCH] drm/sysfs: update outdated comment for renamed drm_sysfs_connector_status_event() Kexin Sun
2026-03-21 17:06 ` Claude review: " Claude Code Review Bot
2026-03-21 17:06 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260321105739.6472-1-kexinsun@smail.nju.edu.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox