public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/sysfs: update outdated comment for renamed drm_sysfs_connector_status_event()
@ 2026-03-21 10:57 Kexin Sun
  2026-03-21 17:06 ` Claude review: " Claude Code Review Bot
  2026-03-21 17:06 ` Claude Code Review Bot
  0 siblings, 2 replies; 3+ messages in thread
From: Kexin Sun @ 2026-03-21 10:57 UTC (permalink / raw)
  To: maarten.lankhorst, mripard, tzimmermann, airlied, simona,
	dri-devel, linux-kernel
  Cc: julia.lawall, xutong.ma, kexinsun, yunbolyu, ratnadiraw

The function drm_sysfs_connector_status_event() was renamed to
drm_sysfs_connector_property_event() by commit 0cf8d292ba5e
("drm/sysfs: rename drm_sysfs_connector_status_event()").  Update
the comment in drm_sysfs_hotplug_event() accordingly, including
changing "connector status change" to "connector property change"
to match the rename rationale.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
 drivers/gpu/drm/drm_sysfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
index ef4e923a8728..c543249d32c3 100644
--- a/drivers/gpu/drm/drm_sysfs.c
+++ b/drivers/gpu/drm/drm_sysfs.c
@@ -438,8 +438,8 @@ void drm_sysfs_lease_event(struct drm_device *dev)
  * set HOTPLUG=1 in the uevent environment, but this could be expanded to
  * deal with other types of events.
  *
- * Any new uapi should be using the drm_sysfs_connector_status_event()
- * for uevents on connector status change.
+ * Any new uapi should be using the drm_sysfs_connector_property_event()
+ * for uevents on connector property change.
  */
 void drm_sysfs_hotplug_event(struct drm_device *dev)
 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Claude review: drm/sysfs: update outdated comment for renamed drm_sysfs_connector_status_event()
  2026-03-21 10:57 [PATCH] drm/sysfs: update outdated comment for renamed drm_sysfs_connector_status_event() Kexin Sun
  2026-03-21 17:06 ` Claude review: " Claude Code Review Bot
@ 2026-03-21 17:06 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-21 17:06 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm/sysfs: update outdated comment for renamed drm_sysfs_connector_status_event()
Author: Kexin Sun <kexinsun@smail.nju.edu.cn>
Patches: 1
Reviewed: 2026-03-22T03:06:17.316702

---

This is a single-patch series that fixes an outdated comment in `drm_sysfs.c`. The function `drm_sysfs_connector_status_event()` was previously renamed to `drm_sysfs_connector_property_event()` in commit `0cf8d292ba5e`, but the comment in `drm_sysfs_hotplug_event()` was not updated to reflect this rename. The fix is straightforward and correct.

**Verdict: Looks good.** Trivial comment-only fix, no functional change.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Claude review: drm/sysfs: update outdated comment for renamed drm_sysfs_connector_status_event()
  2026-03-21 10:57 [PATCH] drm/sysfs: update outdated comment for renamed drm_sysfs_connector_status_event() Kexin Sun
@ 2026-03-21 17:06 ` Claude Code Review Bot
  2026-03-21 17:06 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-21 17:06 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Assessment: Correct and complete.**

The patch makes two changes in the comment block above `drm_sysfs_hotplug_event()`:

1. Updates the function reference:
   ```
   - * Any new uapi should be using the drm_sysfs_connector_status_event()
   + * Any new uapi should be using the drm_sysfs_connector_property_event()
   ```

2. Updates the description to match:
   ```
   - * for uevents on connector status change.
   + * for uevents on connector property change.
   ```

Both changes are accurate — the function is indeed named `drm_sysfs_connector_property_event()` in the current tree (line 490 of `drm_sysfs.c`), and the rename commit `0cf8d292ba5e` is correctly cited.

**Minor nit:** The `Assisted-by: unnamed:deepseek-v3.2 coccinelle` tag is non-standard. The kernel community typically uses tags like `Assisted-by: <tool description>` without mixing tool names with semicolons in this way. However, since this is a trivial comment fix found via tooling, this is unlikely to be a blocker — a maintainer may just ask for the tag to be cleaned up or dropped.

**No technical concerns.** The patch is minimal, correct, and well-described in its commit message.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-21 17:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-21 10:57 [PATCH] drm/sysfs: update outdated comment for renamed drm_sysfs_connector_status_event() Kexin Sun
2026-03-21 17:06 ` Claude review: " Claude Code Review Bot
2026-03-21 17:06 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox