public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vc4: update outdated comment for renamed vc4_crtc_atomic_flush()
Date: Sun, 22 Mar 2026 03:04:07 +1000	[thread overview]
Message-ID: <review-patch1-20260321105743.6562-1-kexinsun@smail.nju.edu.cn> (raw)
In-Reply-To: <20260321105743.6562-1-kexinsun@smail.nju.edu.cn>

Patch Review

**Code change:**
```c
-	 * hardware at vc4_crtc_atomic_flush() time.
+	 * hardware at vc4_hvs_atomic_flush() time.
```

The change is correct. `vc4_crtc_atomic_flush()` no longer exists in the tree, and `vc4_hvs_atomic_flush()` is the current function name (defined in `vc4_hvs.c` and declared in `vc4_drv.h`).

**Minor nits on the commit message:**

1. The `Assisted-by: unnamed:deepseek-v3.2 coccinelle` tag is non-standard. The kernel community hasn't settled on a formal tag for AI-assisted patches, but this format mixing an AI model name with "coccinelle" (a separate semantic patching tool) is confusing. It's unclear whether Coccinelle was used to find the stale reference and DeepSeek was used for something else, or if this is meant as a single attribution. These should probably be separated or clarified.

2. Otherwise the commit message is clear and properly references the commit (`8175287bdd06`) that performed the original rename.

**No functional issues.** 

Reviewed-by assessment: **Acceptable to merge as-is**, though the maintainer may want clarification on the `Assisted-by` tag.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-21 17:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-21 10:57 [PATCH] drm/vc4: update outdated comment for renamed vc4_crtc_atomic_flush() Kexin Sun
2026-03-21 17:04 ` Claude review: " Claude Code Review Bot
2026-03-21 17:04 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260321105743.6562-1-kexinsun@smail.nju.edu.cn \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox