From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vc4: update outdated comment for renamed vc4_crtc_atomic_flush() Date: Sun, 22 Mar 2026 03:04:07 +1000 Message-ID: In-Reply-To: <20260321105743.6562-1-kexinsun@smail.nju.edu.cn> References: <20260321105743.6562-1-kexinsun@smail.nju.edu.cn> <20260321105743.6562-1-kexinsun@smail.nju.edu.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Code change:** ```c - * hardware at vc4_crtc_atomic_flush() time. + * hardware at vc4_hvs_atomic_flush() time. ``` The change is correct. `vc4_crtc_atomic_flush()` no longer exists in the tree, and `vc4_hvs_atomic_flush()` is the current function name (defined in `vc4_hvs.c` and declared in `vc4_drv.h`). **Minor nits on the commit message:** 1. The `Assisted-by: unnamed:deepseek-v3.2 coccinelle` tag is non-standard. The kernel community hasn't settled on a formal tag for AI-assisted patches, but this format mixing an AI model name with "coccinelle" (a separate semantic patching tool) is confusing. It's unclear whether Coccinelle was used to find the stale reference and DeepSeek was used for something else, or if this is meant as a single attribution. These should probably be separated or clarified. 2. Otherwise the commit message is clear and properly references the commit (`8175287bdd06`) that performed the original rename. **No functional issues.** Reviewed-by assessment: **Acceptable to merge as-is**, though the maintainer may want clarification on the `Assisted-by` tag. --- Generated by Claude Code Patch Reviewer