public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: update outdated reference to xe_pt_commit_bind()
@ 2026-03-21 10:57 Kexin Sun
  2026-03-21 17:03 ` Claude review: " Claude Code Review Bot
  2026-03-21 17:03 ` Claude Code Review Bot
  0 siblings, 2 replies; 3+ messages in thread
From: Kexin Sun @ 2026-03-21 10:57 UTC (permalink / raw)
  To: matthew.brost, thomas.hellstrom, rodrigo.vivi, airlied, simona,
	intel-xe, dri-devel, linux-kernel
  Cc: julia.lawall, xutong.ma, kexinsun, yunbolyu, ratnadiraw

The function xe_pt_commit_bind() was split into
xe_pt_commit_prepare_bind(), xe_pt_commit(), and
xe_pt_abort_bind() by commit a708f6501c69 ("drm/xe: Update
PT layer with better error handling").  Update the stale
reference in xe_pt_stage_bind() to list the two functions
that now perform the cpu-side page-table connection.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
 drivers/gpu/drm/xe/xe_pt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
index 13b355fadd58..8f00e6454721 100644
--- a/drivers/gpu/drm/xe/xe_pt.c
+++ b/drivers/gpu/drm/xe/xe_pt.c
@@ -686,7 +686,8 @@ static bool xe_atomic_for_system(struct xe_vm *vm, struct xe_vma *vma)
  *
  * This function builds a disconnected page-table tree for a given address
  * range. The tree is connected to the main vm tree for the gpu using
- * xe_migrate_update_pgtables() and for the cpu using xe_pt_commit_bind().
+ * xe_migrate_update_pgtables() and for the cpu using
+ * xe_pt_commit_prepare_bind() and xe_pt_commit().
  * The function builds xe_vm_pgtable_update structures for already existing
  * shared page-tables, and non-existing shared and non-shared page-tables
  * are built and populated directly.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Claude review: drm/xe: update outdated reference to xe_pt_commit_bind()
  2026-03-21 10:57 [PATCH] drm/xe: update outdated reference to xe_pt_commit_bind() Kexin Sun
  2026-03-21 17:03 ` Claude review: " Claude Code Review Bot
@ 2026-03-21 17:03 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-21 17:03 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm/xe: update outdated reference to xe_pt_commit_bind()
Author: Kexin Sun <kexinsun@smail.nju.edu.cn>
Patches: 1
Reviewed: 2026-03-22T03:03:03.762332

---

This is a single-patch series that fixes a stale comment reference in `xe_pt.c`. The change is trivially correct: `xe_pt_commit_bind()` no longer exists, having been split into `xe_pt_commit_prepare_bind()` and `xe_pt_commit()` (and `xe_pt_abort_bind()`). Both replacement functions are present in the current source at lines 1115 and 1058 respectively, confirming the comment update is accurate.

The patch is **good to merge** with one minor nit below.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Claude review: drm/xe: update outdated reference to xe_pt_commit_bind()
  2026-03-21 10:57 [PATCH] drm/xe: update outdated reference to xe_pt_commit_bind() Kexin Sun
@ 2026-03-21 17:03 ` Claude Code Review Bot
  2026-03-21 17:03 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-03-21 17:03 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Correctness**: The comment fix is accurate. The old function `xe_pt_commit_bind()` was indeed split, and the two functions referenced (`xe_pt_commit_prepare_bind()` at line 1115 and `xe_pt_commit()` at line 1058) both exist and are used in the codebase.

**Nit on the "Assisted-by" tag**: The tag `Assisted-by: unnamed:deepseek-v3.2 coccinelle` is non-standard. The kernel community has debated AI-assisted contribution tags, and this format doesn't follow any established convention. It's unclear what "unnamed:deepseek-v3.2 coccinelle" means — was Coccinelle used to find the stale reference and DeepSeek used to draft the fix? A maintainer may ask for clarification or removal of this tag.

**Minor**: The commit message accurately references commit `a708f6501c69` as the source of the split, which is good practice for traceability.

**Verdict**: The code change itself is correct and trivial. The only point of discussion is the non-standard `Assisted-by` trailer.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-21 17:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-21 10:57 [PATCH] drm/xe: update outdated reference to xe_pt_commit_bind() Kexin Sun
2026-03-21 17:03 ` Claude review: " Claude Code Review Bot
2026-03-21 17:03 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox