From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: fix dead default for DRM_TTM_KUNIT_TEST Date: Wed, 25 Mar 2026 08:10:58 +1000 Message-ID: In-Reply-To: <20260322220125.1380776-1-julianbraha@gmail.com> References: <20260322220125.1380776-1-julianbraha@gmail.com> <20260322220125.1380776-1-julianbraha@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness:** The patch correctly removes the `default n` line. After re= moval, the remaining `default KUNIT_ALL_TESTS` will properly take effect = =E2=80=94 defaulting to `y` when `KUNIT_ALL_TESTS=3Dy`, and to `n` otherwis= e (since Kconfig tristates default to `n` when no default matches). **Commit message:** Clear and well-written. Correctly identifies the proble= m (shadowed default), references the tool that found it, and includes a pro= per `Fixes:` tag pointing to commit `e3912d09bf8d ("drm/ttm: Introduce KUni= t test")`. **Style note:** After this patch, the `default KUNIT_ALL_TESTS` line (curre= ntly line 94 in the tree) sits after the `select` statements, which matches= the ordering used by `DRM_KUNIT_TEST` and `DRM_SCHED_KUNIT_TEST` in the sa= me file. No issues there. **One minor observation:** The ordering convention in this file for the oth= er entries places `default KUNIT_ALL_TESTS` *after* the `select` blocks. Th= e patched result preserves that convention, which is good. Reviewed-by assessment: This patch is correct and ready to apply. --- Generated by Claude Code Patch Reviewer