From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: Use register! macro for GPU_CONTROL Date: Wed, 25 Mar 2026 07:08:42 +1000 Message-ID: In-Reply-To: <20260323-b4-tyr-use-register-macro-v3-v3-1-a87daf9e4701@collabora.com> References: <20260323-b4-tyr-use-register-macro-v3-v3-0-a87daf9e4701@collabora.com> <20260323-b4-tyr-use-register-macro-v3-v3-1-a87daf9e4701@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The major patch converting all GPU_CONTROL registers. Well done overall. The `GPU_COMMAND` register uses an interesting pattern with layout aliases = (`GPU_COMMAND_RESET`, `GPU_COMMAND_FLUSH`) via `=3D> GPU_COMMAND` to handle= the multiple command formats. The constructor methods on `GPU_COMMAND` (`.= reset()`, `.flush_caches()`, `.clear_fault()`) provide a clean API. Minor: The `Io` import uses a trailing `//` comment as a formatting hint: ```rust io::{ poll, Io, // }, ``` This is a rustfmt workaround to force multi-line formatting =E2=80=93 funct= ional but slightly unusual. The `ExceptionType` enum at `Bounded` (8-bit field) correctly cover= s GPU fault types 0x00, 0x80, 0x88, 0x89, 0x8A, all of which fit in 8 bits. The `with_const_request::<1>()` call in `l2_power_on` is a nice use of cons= t generics for compile-time-known values. --- Generated by Claude Code Patch Reviewer