From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: panel: Add ChipWealth CH13726A AMOLED driver Date: Wed, 25 Mar 2026 07:40:21 +1000 Message-ID: In-Reply-To: <20260323-ch13726a-v3-1-e28b6f97fe80@gmail.com> References: <20260323-ch13726a-v3-0-e28b6f97fe80@gmail.com> <20260323-ch13726a-v3-1-e28b6f97fe80@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The binding looks reasonable. A few notes: 1. **`port` should probably be required.** Most DSI panel bindings require = the `port` property so the panel can be connected to the DSI host in the de= vice tree graph. It's listed as optional here but not included in the examp= le either: ```yaml port: true reset-gpios: true rotation: true ``` The example should include a `port` node to show proper usage. 2. **The compatible string is device-specific, not chip-specific.** The bin= ding file is named `chipwealth,ch13726a.yaml` and the title references the = CH13726A chip, but the only compatible is `"ayntec,thor-panel-bottom"`. Thi= s is a reasonable pattern (the panel module is specific to the device), but= it's worth noting the naming inconsistency =E2=80=94 the YAML filename sug= gests a chipwealth vendor prefix while the compatible uses `ayntec`. If oth= er boards use the CH13726A in the future, a `chipwealth,ch13726a` compatibl= e as a fallback might be useful. 3. **Minor: `rotation` vs DT panel-common.** The `panel-common.yaml` refere= nce already covers `rotation`, so explicitly listing `rotation: true` is fi= ne for clarity but redundant. --- Generated by Claude Code Patch Reviewer