public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: sharp-ls043t1le01: make use of prepare_prev_first
Date: Wed, 25 Mar 2026 08:09:54 +1000	[thread overview]
Message-ID: <review-patch1-20260323-panel-fix-v1-1-9f12b09161e8@oss.qualcomm.com> (raw)
In-Reply-To: <20260323-panel-fix-v1-1-9f12b09161e8@oss.qualcomm.com>

Patch Review

**Correctness:** The `prepare()` callback at line 102 calls `sharp_nt_panel_init()` which issues DSI commands (`mipi_dsi_dcs_exit_sleep_mode_multi`, `mipi_dsi_dcs_write_seq_multi`, etc.), and then `sharp_nt_panel_on()` which calls `mipi_dsi_dcs_set_display_on_multi`. All of these require an active DSI link. Setting `prepare_prev_first` is the correct fix.

**Placement:** The assignment:
```c
sharp_nt->base.prepare_prev_first = true;
```
is placed right after `drm_panel_init()` and before `drm_panel_of_backlight()`, which matches the pattern used across dozens of other panel drivers (e.g., `panel-boe-bf060y8m-aj0.c:353`, `panel-boe-tv101wum-nl6.c:1721`, etc.).

**Fixes tag:** Correctly references 9e15123eca79 which introduced the regression by stopping unconditional DSI host power-up.

**No issues found.** Clean, minimal, correct fix.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-24 22:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23  1:21 [PATCH] drm/panel: sharp-ls043t1le01: make use of prepare_prev_first Dmitry Baryshkov
2026-03-23 14:59 ` Doug Anderson
2026-03-24 22:09 ` Claude review: " Claude Code Review Bot
2026-03-24 22:09 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260323-panel-fix-v1-1-9f12b09161e8@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox