From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: sharp-ls043t1le01: make use of prepare_prev_first Date: Wed, 25 Mar 2026 08:09:54 +1000 Message-ID: In-Reply-To: <20260323-panel-fix-v1-1-9f12b09161e8@oss.qualcomm.com> References: <20260323-panel-fix-v1-1-9f12b09161e8@oss.qualcomm.com> <20260323-panel-fix-v1-1-9f12b09161e8@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Correctness:** The `prepare()` callback at line 102 calls `sharp_nt_panel_init()` which issues DSI commands (`mipi_dsi_dcs_exit_sleep_mode_multi`, `mipi_dsi_dcs_write_seq_multi`, etc.), and then `sharp_nt_panel_on()` which calls `mipi_dsi_dcs_set_display_on_multi`. All of these require an active DSI link. Setting `prepare_prev_first` is the correct fix. **Placement:** The assignment: ```c sharp_nt->base.prepare_prev_first = true; ``` is placed right after `drm_panel_init()` and before `drm_panel_of_backlight()`, which matches the pattern used across dozens of other panel drivers (e.g., `panel-boe-bf060y8m-aj0.c:353`, `panel-boe-tv101wum-nl6.c:1721`, etc.). **Fixes tag:** Correctly references 9e15123eca79 which introduced the regression by stopping unconditional DSI host power-up. **No issues found.** Clean, minimal, correct fix. --- Generated by Claude Code Patch Reviewer