From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: correct firmware related messages
Date: Wed, 25 Mar 2026 08:01:15 +1000 [thread overview]
Message-ID: <review-patch1-20260323081132.3217646-1-christianshewitt@gmail.com> (raw)
In-Reply-To: <20260323081132.3217646-1-christianshewitt@gmail.com>
Patch Review
**Fix 1** (line 110): Changes `"Firmware protected mode entry not be supported, ignoring"` to `"Firmware protected mode entry is not supported, ignoring"` — clearly a grammar fix for a broken sentence ("not be supported" → "is not supported"). Correct.
**Fix 2** (line 120): Changes `"Firmware entry isn't 32 bit aligned"` to `"Firmware entry is not 32-bit aligned"` — two changes here:
- `isn't` → `is not`: stylistic preference for formal language in kernel messages. Reasonable, though the kernel has no strict rule against contractions.
- `32 bit` → `32-bit`: correct hyphenation when used as a compound adjective. This is the more substantive language fix.
Both changes confirmed against the current drm-next tree. The patch is straightforward, low-risk, and improves message clarity.
**Reviewed-by: appropriate** — no issues found.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 8:11 [PATCH] drm/panthor: correct firmware related messages Christian Hewitt
2026-03-23 8:22 ` Boris Brezillon
2026-03-23 11:18 ` Liviu Dudau
2026-03-24 16:06 ` Liviu Dudau
2026-03-24 22:01 ` Claude Code Review Bot [this message]
2026-03-24 22:01 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260323081132.3217646-1-christianshewitt@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox