From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/ivpu: Add disable clock relinquish workaround for NVL-A0
Date: Wed, 25 Mar 2026 08:00:05 +1000 [thread overview]
Message-ID: <review-patch1-20260323095029.64613-1-karol.wachowski@linux.intel.com> (raw)
In-Reply-To: <20260323095029.64613-1-karol.wachowski@linux.intel.com>
Patch Review
**Change summary:** Defines `IVPU_HW_IP_REV_NVL_A0` as 0 in `ivpu_drv.h` and extends the `wa_init()` condition in `ivpu_hw.c` to also enable the `disable_clock_relinquish` workaround for NVL A0 devices.
**Review:**
1. **`IVPU_HW_IP_REV_NVL_A0 0` definition** — Placed logically next to the existing `IVPU_HW_IP_REV_LNL_B0` define. Fine.
2. **Condition logic in `wa_init()`:**
```c
if ((ivpu_device_id(vdev) == PCI_DEVICE_ID_LNL &&
ivpu_revision(vdev) < IVPU_HW_IP_REV_LNL_B0) ||
(ivpu_device_id(vdev) == PCI_DEVICE_ID_NVL &&
ivpu_revision(vdev) == IVPU_HW_IP_REV_NVL_A0))
```
The LNL case uses `<` (all revisions before B0) while NVL uses `==` (only A0). This is intentional — NVL A0 revision is 0, so using `<` would match nothing (`< 0` is impossible for what is presumably an unsigned value). Using `==` is the correct approach here, and it also signals that only the A0 stepping needs the workaround, not future revisions.
3. **Cc: stable with version tag** — The `Cc: <stable@vger.kernel.org> # v6.19+` is correct since that's when NVL support was added via commit `550f4dd2cedd`.
4. **Fixes tag** — Points to the NVL support commit, which is appropriate — the workaround should have been included when NVL was first added.
No issues. The patch is clean, minimal, and correct.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 9:50 [PATCH] accel/ivpu: Add disable clock relinquish workaround for NVL-A0 Karol Wachowski
2026-03-23 16:53 ` Lizhi Hou
2026-03-24 8:32 ` Karol Wachowski
2026-03-24 22:00 ` Claude Code Review Bot [this message]
2026-03-24 22:00 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260323095029.64613-1-karol.wachowski@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox