From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/ivpu: Add disable clock relinquish workaround for NVL-A0 Date: Wed, 25 Mar 2026 08:00:05 +1000 Message-ID: In-Reply-To: <20260323095029.64613-1-karol.wachowski@linux.intel.com> References: <20260323095029.64613-1-karol.wachowski@linux.intel.com> <20260323095029.64613-1-karol.wachowski@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Change summary:** Defines `IVPU_HW_IP_REV_NVL_A0` as 0 in `ivpu_drv.h` an= d extends the `wa_init()` condition in `ivpu_hw.c` to also enable the `disa= ble_clock_relinquish` workaround for NVL A0 devices. **Review:** 1. **`IVPU_HW_IP_REV_NVL_A0 0` definition** =E2=80=94 Placed logically next= to the existing `IVPU_HW_IP_REV_LNL_B0` define. Fine. 2. **Condition logic in `wa_init()`:** ```c if ((ivpu_device_id(vdev) =3D=3D PCI_DEVICE_ID_LNL && ivpu_revision(vdev) < IVPU_HW_IP_REV_LNL_B0) || (ivpu_device_id(vdev) =3D=3D PCI_DEVICE_ID_NVL && ivpu_revision(vdev) =3D=3D IVPU_HW_IP_REV_NVL_A0)) ``` The LNL case uses `<` (all revisions before B0) while NVL uses `=3D=3D` = (only A0). This is intentional =E2=80=94 NVL A0 revision is 0, so using `<`= would match nothing (`< 0` is impossible for what is presumably an unsigne= d value). Using `=3D=3D` is the correct approach here, and it also signals = that only the A0 stepping needs the workaround, not future revisions. 3. **Cc: stable with version tag** =E2=80=94 The `Cc: # v6.19+` is correct since that's when NVL support was added via commit= `550f4dd2cedd`. 4. **Fixes tag** =E2=80=94 Points to the NVL support commit, which is appro= priate =E2=80=94 the workaround should have been included when NVL was firs= t added. No issues. The patch is clean, minimal, and correct. --- Generated by Claude Code Patch Reviewer