public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: fix dead default for DRM_TTM_KUNIT_TEST
Date: Wed, 25 Mar 2026 07:52:19 +1000	[thread overview]
Message-ID: <review-patch1-20260323124118.1414913-1-julianbraha@gmail.com> (raw)
In-Reply-To: <20260323124118.1414913-1-julianbraha@gmail.com>

Patch Review

**Commit message:** Clear and well-written. Explains the problem (shadowed default), the tool that found it (kconfirm), and what the fix does.

**Code change:** Correct. Looking at the existing file (`Kconfig.debug:86-94`), we can see:

```
config DRM_TTM_KUNIT_TEST
	tristate "KUnit tests for TTM" if !KUNIT_ALL_TESTS
	default n                      <-- first default, always wins
	depends on DRM && KUNIT && MMU && (UML || COMPILE_TEST)
	select DRM_TTM
	select DRM_BUDDY
	select DRM_EXPORT_FOR_TESTS if m
	select DRM_KUNIT_TEST_HELPERS
	default KUNIT_ALL_TESTS        <-- dead code, never reached
```

Removing `default n` makes `default KUNIT_ALL_TESTS` the sole default, which is the intended behavior. This is consistent with the pattern used by `DRM_SCHED_KUNIT_TEST` (line 103-107) and `DRM_KUNIT_TEST` earlier in the same file, which don't have a `default n` overriding their `default KUNIT_ALL_TESTS`.

**Minor style note:** After removal, the `default KUNIT_ALL_TESTS` on line 94 sits after several `select` statements. It would be slightly more conventional to place `default` right after `depends on` (matching `DRM_SCHED_KUNIT_TEST`'s ordering), but that's a purely cosmetic nit and not worth blocking the patch.

**Reviewed-by worthy:** Yes, this is a clean, correct fix.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-24 21:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 12:41 [PATCH v2] drm: fix dead default for DRM_TTM_KUNIT_TEST Julian Braha
2026-03-24 16:04 ` Christian König
2026-03-24 21:52 ` Claude review: " Claude Code Review Bot
2026-03-24 21:52 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-22 22:01 [PATCH] " Julian Braha
2026-03-24 22:10 ` Claude review: " Claude Code Review Bot
2026-03-24 22:10 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260323124118.1414913-1-julianbraha@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox