From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vblank: Add drm_crtc_vblank_is_off() helper
Date: Wed, 25 Mar 2026 07:22:01 +1000 [thread overview]
Message-ID: <review-patch1-20260323202755.315929-2-sunpeng.li@amd.com> (raw)
In-Reply-To: <20260323202755.315929-2-sunpeng.li@amd.com>
Patch Review
Clean, straightforward patch. The replacement in `drm_atomic_helper_commit_crtc_disable` removes the side-effectful `drm_crtc_vblank_get()`/`drm_crtc_vblank_put()` pair that was only being used to check if vblank_off had been called. Good preparation for patch 2.
Minor nit: the function is exported (`EXPORT_SYMBOL`) but placed in `drm_internal.h`. That combination is unusual — it means out-of-tree modules could call it but in-tree headers don't expose it. Since it's only used internally, maybe just don't export it, or use `EXPORT_SYMBOL_GPL` if future driver use is anticipated.
The condition `vblank->inmodeset && !vblank->enabled` correctly captures the "vblank_off was called" state, which sets `inmodeset` and disables vblank.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 21:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 20:27 [PATCH v2 0/5] drm/vblank: Deferred Enable and Disable sunpeng.li
2026-03-23 20:27 ` [PATCH v2 1/5] drm/vblank: Add drm_crtc_vblank_is_off() helper sunpeng.li
2026-03-24 20:20 ` Mario Limonciello
2026-03-24 21:22 ` Claude Code Review Bot [this message]
2026-03-23 20:27 ` [PATCH v2 2/5] drm/vblank: Introduce deferred vblank enable/disable sunpeng.li
2026-03-24 21:22 ` Claude review: " Claude Code Review Bot
2026-03-23 20:27 ` [PATCH v2 3/5] drm/amd/display: Refactor amdgpu_dm_crtc_set_vblank sunpeng.li
2026-03-24 21:22 ` Claude review: " Claude Code Review Bot
2026-03-23 20:27 ` [PATCH v2 4/5] drm/amd/display: Implement deferred vblanks on IPS platforms sunpeng.li
2026-03-24 21:22 ` Claude review: " Claude Code Review Bot
2026-03-23 20:27 ` [PATCH v2 5/5] drm/vblank: Add some debugging trace events sunpeng.li
2026-03-24 21:22 ` Claude review: " Claude Code Review Bot
2026-03-24 21:22 ` Claude review: drm/vblank: Deferred Enable and Disable Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-02-24 21:26 [PATCH 0/5] " sunpeng.li
2026-02-24 21:26 ` [PATCH 1/5] drm/vblank: Add drm_crtc_vblank_is_off() helper sunpeng.li
2026-02-27 4:40 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260323202755.315929-2-sunpeng.li@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox