From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vblank: Add drm_crtc_vblank_is_off() helper Date: Wed, 25 Mar 2026 07:22:01 +1000 Message-ID: In-Reply-To: <20260323202755.315929-2-sunpeng.li@amd.com> References: <20260323202755.315929-1-sunpeng.li@amd.com> <20260323202755.315929-2-sunpeng.li@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean, straightforward patch. The replacement in `drm_atomic_helper_commit_= crtc_disable` removes the side-effectful `drm_crtc_vblank_get()`/`drm_crtc_= vblank_put()` pair that was only being used to check if vblank_off had been= called. Good preparation for patch 2. Minor nit: the function is exported (`EXPORT_SYMBOL`) but placed in `drm_in= ternal.h`. That combination is unusual =E2=80=94 it means out-of-tree modul= es could call it but in-tree headers don't expose it. Since it's only used = internally, maybe just don't export it, or use `EXPORT_SYMBOL_GPL` if futur= e driver use is anticipated. The condition `vblank->inmodeset && !vblank->enabled` correctly captures th= e "vblank_off was called" state, which sets `inmodeset` and disables vblank. --- Generated by Claude Code Patch Reviewer