public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vblank: Extract get_vblank_counter_and_timestamp()
Date: Wed, 25 Mar 2026 07:15:59 +1000	[thread overview]
Message-ID: <review-patch1-20260323213645.10965-1-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260323213645.10965-1-ville.syrjala@linux.intel.com>

Patch Review

**Correctness:**

The three original do/while loops are identical in structure:
```c
do {
    cur_vblank = __get_vblank_counter(dev, pipe);
    rc = drm_get_last_vbltimestamp(dev, pipe, &t_vblank, in_vblank_irq);
} while (cur_vblank != __get_vblank_counter(dev, pipe) && --count > 0);
```

The new helper faithfully reproduces this pattern. Two of the three call sites (`drm_reset_vblank_timestamp` and `drm_update_vblank_count`) used the return value (`rc`) — the refactored code preserves this.

**Minor observation:** In `drm_vblank_restore()` (line 1563 in the original), the return value of `drm_get_last_vbltimestamp()` was **not** captured:
```c
drm_get_last_vbltimestamp(dev, pipe, &t_vblank, false);
```
The new code now captures it via the helper's `rc` return, but the caller discards the return value:
```c
get_vblank_counter_and_timestamp(dev, pipe, &cur_vblank,
                                 &t_vblank, false);
```
This is harmless — the return value is simply ignored — but it does mean the refactoring subtly changes the code from "never captured" to "captured then discarded." No functional impact.

**Style:** The helper is well-placed (right after `__get_vblank_counter()`), the naming is descriptive, and the parameter list matches the existing patterns in the file.

**Reviewed-by worthy:** Yes, this is a clean extraction with no behavioral changes.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-24 21:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 21:36 [PATCH] drm/vblank: Extract get_vblank_counter_and_timestamp() Ville Syrjala
2026-03-24  6:28 ` Kandpal, Suraj
2026-03-24 21:15 ` Claude Code Review Bot [this message]
2026-03-24 21:15 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260323213645.10965-1-ville.syrjala@linux.intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox