public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: drm_bridge_get/put(): document NULL pointer behaviour
Date: Wed, 25 Mar 2026 06:56:51 +1000	[thread overview]
Message-ID: <review-patch1-20260324-drm-bridge-alloc-getput-document-null-check-v1-1-fb0877c49d7e@bootlin.com> (raw)
In-Reply-To: <20260324-drm-bridge-alloc-getput-document-null-check-v1-1-fb0877c49d7e@bootlin.com>

Patch Review

The patch updates the `@bridge` parameter documentation for both `drm_bridge_get()` and `drm_bridge_put()` from:

```
- * @bridge: DRM bridge
+ * @bridge: DRM bridge; if NULL this function does nothing
```

**Correctness:** Verified against the implementation. Both functions have an `if (bridge)` guard (lines 294 and 310 of `drm_bridge.c`), so the documentation accurately describes the behavior.

**Motivation:** Well explained in the commit message — there's existing code that relies on this (e.g., `__free(drm_bridge_put)` cleanup patterns at lines 1042, 1166, 1230), and callers should be able to depend on it without ambiguity.

**Nit:** For `drm_bridge_get()`, it might be worth also noting the return value in the NULL case (returns NULL), since the function has a documented `Returns: Pointer to @bridge` — but this is minor and the current wording is consistent with how similar kernel APIs (like `kfree`) document their NULL tolerance.

**Reviewed-by: No issues found.**

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-24 20:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24  9:08 [PATCH RESEND] drm/bridge: drm_bridge_get/put(): document NULL pointer behaviour Luca Ceresoli
2026-03-24 20:56 ` Claude review: " Claude Code Review Bot
2026-03-24 20:56 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260324-drm-bridge-alloc-getput-document-null-check-v1-1-fb0877c49d7e@bootlin.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox