From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: drm_bridge_get/put(): document NULL pointer behaviour Date: Wed, 25 Mar 2026 06:56:51 +1000 Message-ID: In-Reply-To: <20260324-drm-bridge-alloc-getput-document-null-check-v1-1-fb0877c49d7e@bootlin.com> References: <20260324-drm-bridge-alloc-getput-document-null-check-v1-1-fb0877c49d7e@bootlin.com> <20260324-drm-bridge-alloc-getput-document-null-check-v1-1-fb0877c49d7e@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The patch updates the `@bridge` parameter documentation for both `drm_bridg= e_get()` and `drm_bridge_put()` from: ``` - * @bridge: DRM bridge + * @bridge: DRM bridge; if NULL this function does nothing ``` **Correctness:** Verified against the implementation. Both functions have a= n `if (bridge)` guard (lines 294 and 310 of `drm_bridge.c`), so the documen= tation accurately describes the behavior. **Motivation:** Well explained in the commit message =E2=80=94 there's exis= ting code that relies on this (e.g., `__free(drm_bridge_put)` cleanup patte= rns at lines 1042, 1166, 1230), and callers should be able to depend on it = without ambiguity. **Nit:** For `drm_bridge_get()`, it might be worth also noting the return v= alue in the NULL case (returns NULL), since the function has a documented `= Returns: Pointer to @bridge` =E2=80=94 but this is minor and the current wo= rding is consistent with how similar kernel APIs (like `kfree`) document th= eir NULL tolerance. **Reviewed-by: No issues found.** --- Generated by Claude Code Patch Reviewer