From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: verisilicon: add max cursor size to HWDB Date: Wed, 25 Mar 2026 07:03:51 +1000 Message-ID: In-Reply-To: <20260324060222.2029061-2-zhengxingda@iscas.ac.cn> References: <20260324060222.2029061-1-zhengxingda@iscas.ac.cn> <20260324060222.2029061-2-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This patch is straightforward and correct. **Minor: use `u32` instead of `int32_t`** ```c int32_t max_cursor_size; ``` The value is always positive (32, 64, etc.) and is compared against unsigne= d values. The rest of the struct uses `u32` for similar fields (`display_co= unt`). Using `int32_t` (a POSIX type) is unusual in kernel struct definitio= ns =E2=80=94 prefer `u32` for consistency, or `s32` if signed is truly inte= nded. **No other issues.** All four HWDB entries are populated with 64, matching = the cover letter's claim that DC8200 supports 32x32 and 64x64. --- Generated by Claude Code Patch Reviewer