[PATCH -next] drm: verisilicon: make vs_dc_platform_driver static

[PATCH -next] drm: verisilicon: make vs_dc_platform_driver static

[Icenowy Zheng]

The platform_driver struct isn't export and is only used for module
init/exit functions generated by module_platform_driver() macro.

Make it static to prevent namespace pollution.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603180616.TM6qYvIY-lkp@intel.com/
Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
---
 drivers/gpu/drm/verisilicon/vs_dc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/verisilicon/vs_dc.c b/drivers/gpu/drm/verisilicon/vs_dc.c
index 5f629d2d4beac..dad9967bc10b8 100644
--- a/drivers/gpu/drm/verisilicon/vs_dc.c
+++ b/drivers/gpu/drm/verisilicon/vs_dc.c
@@ -190,7 +190,7 @@ static void vs_dc_shutdown(struct platform_device *pdev)
 	vs_drm_shutdown_handler(dc);
 }
 
-struct platform_driver vs_dc_platform_driver = {
+static struct platform_driver vs_dc_platform_driver = {
 	.probe = vs_dc_probe,
 	.remove = vs_dc_remove,
 	.shutdown = vs_dc_shutdown,
-- 
2.52.0

Re: [PATCH -next] drm: verisilicon: make vs_dc_platform_driver static

[Thomas Zimmermann]

Am 24.03.26 um 07:08 schrieb Icenowy Zheng:
> The platform_driver struct isn't export and is only used for module
> init/exit functions generated by module_platform_driver() macro.
>
> Make it static to prevent namespace pollution.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202603180616.TM6qYvIY-lkp@intel.com/
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/gpu/drm/verisilicon/vs_dc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/verisilicon/vs_dc.c b/drivers/gpu/drm/verisilicon/vs_dc.c
> index 5f629d2d4beac..dad9967bc10b8 100644
> --- a/drivers/gpu/drm/verisilicon/vs_dc.c
> +++ b/drivers/gpu/drm/verisilicon/vs_dc.c
> @@ -190,7 +190,7 @@ static void vs_dc_shutdown(struct platform_device *pdev)
>   	vs_drm_shutdown_handler(dc);
>   }
>   
> -struct platform_driver vs_dc_platform_driver = {
> +static struct platform_driver vs_dc_platform_driver = {
>   	.probe = vs_dc_probe,
>   	.remove = vs_dc_remove,
>   	.shutdown = vs_dc_shutdown,

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)

Claude review: drm: verisilicon: make vs_dc_platform_driver static

[Claude Code Review Bot]

Patch Review

**Assessment: Correct and complete.**

The patch adds `static` to the `vs_dc_platform_driver` struct:

```c
-struct platform_driver vs_dc_platform_driver = {
+static struct platform_driver vs_dc_platform_driver = {
```

I confirmed that `vs_dc_platform_driver` is only referenced in `vs_dc.c` itself — it appears at its definition (line 193) and in the `module_platform_driver()` macro invocation (line 203). There is no `extern` declaration in any header, and no other file references it. Making it `static` is the right fix to avoid the sparse/build warning about a non-static symbol without a prototype.

The commit message is clear, references the kernel test robot report, and includes a `Closes:` tag. No issues found.

**Reviewed-by: appropriate.**

---
Generated by Claude Code Patch Reviewer

Claude review: drm: verisilicon: make vs_dc_platform_driver static

[Claude Code Review Bot]

Overall Series Review

Subject: drm: verisilicon: make vs_dc_platform_driver static
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Patches: 2
Reviewed: 2026-03-25T07:02:12.695734

---

This is a single, trivial patch that adds `static` to `vs_dc_platform_driver` in the Verisilicon DC driver. The change is correct and straightforward — the symbol is only referenced within the same file via `module_platform_driver()`, so it should indeed be static.

**Verdict: Looks good.**

---
Generated by Claude Code Patch Reviewer