public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel-edp: Add 2 panels used by MT8186 Chromebooks
Date: Wed, 25 Mar 2026 07:01:00 +1000	[thread overview]
Message-ID: <review-patch1-20260324061444.242917-1-terry_hsiao@compal.corp-partner.google.com> (raw)
In-Reply-To: <20260324061444.242917-1-terry_hsiao@compal.corp-partner.google.com>

Patch Review

**EDID verification:**
- **CSW PNB601LS1-2**: EDID bytes 8-9 = `0e 77` (CSW), product code bytes 10-11 = `0a 11` → little-endian = `0x110A`. Matches the entry.
- **LGD LP116WHA-SPB1**: EDID bytes 8-9 = `30 e4` (LGD), product code bytes 10-11 = `fe 07` → little-endian = `0x07FE`. Matches the entry.

**Sort order:** Both entries are inserted in the correct hex-sorted position within their manufacturer groups.

**Delay values:**
- The LGD entry uses `&delay_200_500_e200_d200`, which is consistent with every other LGD panel in the table. No concerns there.
- The CSW entry uses `&delay_200_500_e50`. The other CSW panels in the MNB601LS1 family use different delays:
  - `0x1100` MNB601LS1-1 → `delay_200_500_e80_d50`
  - `0x1103` MNB601LS1-3 → `delay_200_500_e80_d50`
  - `0x1104` MNB601LS1-4 → `delay_200_500_e50_d100`

  The new PNB601LS1-2 uses `delay_200_500_e50` (no deassert delay). This is a different panel family name prefix (PNB vs MNB), so different timing could be expected, but it would be good for the author to confirm the power-off-to-on delay (`d`) and enable delay (`e`) values were verified against the panel datasheet.

**Minor nit:** The commit subject says "2 panels" but doesn't mention the specific platform context in the diff itself. This is fine for a panel-edp data patch.

**No functional issues found.** The patch is correct and ready to merge, assuming the delay values for the CSW panel have been validated on hardware.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-24 21:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24  6:14 [PATCH v1] drm/panel-edp: Add 2 panels used by MT8186 Chromebooks Terry Hsiao
2026-03-24 21:01 ` Claude Code Review Bot [this message]
2026-03-24 21:01 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260324061444.242917-1-terry_hsiao@compal.corp-partner.google.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox