public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/syncobj: Fix xa_alloc allocation flags
Date: Wed, 25 Mar 2026 06:54:13 +1000	[thread overview]
Message-ID: <review-patch1-20260324111019.22467-1-tvrtko.ursulin@igalia.com> (raw)
In-Reply-To: <20260324111019.22467-1-tvrtko.ursulin@igalia.com>

Patch Review

**Correctness: Good.** Both call sites (`drm_syncobj_get_handle` at line 604 and `drm_syncobj_fd_to_handle` at line 718) are in process/ioctl context with no spinlocks held, so `GFP_KERNEL` is safe to use.

The commit message clearly explains the rationale: `idr_preload(GFP_KERNEL)` + `idr_alloc(..., GFP_NOWAIT)` was a standard IDR pattern where preload pre-allocated memory allowing the subsequent alloc to use `GFP_NOWAIT`. The xarray conversion removed `idr_preload` but kept `GFP_NOWAIT`, meaning `xa_alloc` could fail under memory pressure where the old code would have succeeded.

**Tags:** The `Fixes:` tag correctly references the commit that introduced the regression. `Reported-by` and `Cc` tags are present.

**Minor nit:** The `Fixes:` tag is placed after `Signed-off-by:`, which is unconventional — it's more common to place `Fixes:` before `Signed-off-by:`. This is a stylistic preference and doesn't affect anything functionally.

**No issues found.** The patch is clean, minimal, and correct.

**Reviewed-by worthy:** Yes.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-24 20:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 11:10 [PATCH] drm/syncobj: Fix xa_alloc allocation flags Tvrtko Ursulin
2026-03-24 11:12 ` Thomas Hellström
2026-03-24 11:27 ` Girotra, Himanshu
2026-03-24 20:54 ` Claude review: " Claude Code Review Bot
2026-03-24 20:54 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260324111019.22467-1-tvrtko.ursulin@igalia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox