From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/syncobj: Fix xa_alloc allocation flags Date: Wed, 25 Mar 2026 06:54:13 +1000 Message-ID: In-Reply-To: <20260324111019.22467-1-tvrtko.ursulin@igalia.com> References: <20260324111019.22467-1-tvrtko.ursulin@igalia.com> <20260324111019.22467-1-tvrtko.ursulin@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** Both call sites (`drm_syncobj_get_handle` at line 60= 4 and `drm_syncobj_fd_to_handle` at line 718) are in process/ioctl context = with no spinlocks held, so `GFP_KERNEL` is safe to use. The commit message clearly explains the rationale: `idr_preload(GFP_KERNEL)= ` + `idr_alloc(..., GFP_NOWAIT)` was a standard IDR pattern where preload p= re-allocated memory allowing the subsequent alloc to use `GFP_NOWAIT`. The = xarray conversion removed `idr_preload` but kept `GFP_NOWAIT`, meaning `xa_= alloc` could fail under memory pressure where the old code would have succe= eded. **Tags:** The `Fixes:` tag correctly references the commit that introduced = the regression. `Reported-by` and `Cc` tags are present. **Minor nit:** The `Fixes:` tag is placed after `Signed-off-by:`, which is = unconventional =E2=80=94 it's more common to place `Fixes:` before `Signed-= off-by:`. This is a stylistic preference and doesn't affect anything functi= onally. **No issues found.** The patch is clean, minimal, and correct. **Reviewed-by worthy:** Yes. --- Generated by Claude Code Patch Reviewer