From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/xe_pagefault: Disallow writes to read-only VMAs
Date: Wed, 25 Mar 2026 06:46:43 +1000 [thread overview]
Message-ID: <review-patch1-20260324152935.72444-7-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20260324152935.72444-7-jonathan.cavitt@intel.com>
Patch Review
Clean, straightforward bug fix. Has a `Reviewed-by` and `Fixes` tag.
```c
if (xe_vma_read_only(vma) &&
pf->consumer.access_type != XE_PAGEFAULT_ACCESS_TYPE_READ) {
err = -EPERM;
goto unlock_vm;
}
```
This correctly catches both WRITE and ATOMIC access to read-only VMAs. The placement after the VMA lookup and before the atomic check is appropriate. No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-24 20:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 15:29 [PATCH v39 0/4] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Jonathan Cavitt
2026-03-24 15:29 ` [PATCH v39 1/4] drm/xe/xe_pagefault: Disallow writes to read-only VMAs Jonathan Cavitt
2026-03-24 20:46 ` Claude Code Review Bot [this message]
2026-03-24 15:29 ` [PATCH v39 2/4] drm/xe/uapi: Define drm_xe_vm_get_property Jonathan Cavitt
2026-03-24 20:46 ` Claude review: " Claude Code Review Bot
2026-03-24 15:29 ` [PATCH v39 3/4] drm/xe/xe_vm: Add per VM fault info Jonathan Cavitt
2026-03-24 20:46 ` Claude review: " Claude Code Review Bot
2026-03-24 15:29 ` [PATCH v39 4/4] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Jonathan Cavitt
2026-03-24 20:46 ` Claude review: " Claude Code Review Bot
2026-03-24 20:46 ` Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-20 18:35 [PATCH v38 0/4] " Jonathan Cavitt
2026-03-20 18:35 ` [PATCH v38 1/4] drm/xe/xe_pagefault: Disallow writes to read-only VMAs Jonathan Cavitt
2026-03-21 17:27 ` Claude review: " Claude Code Review Bot
2026-03-10 14:49 [PATCH v37 0/4] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Jonathan Cavitt
2026-03-10 14:49 ` [PATCH v37 1/4] drm/xe/xe_pagefault: Disallow writes to read-only VMAs Jonathan Cavitt
2026-03-11 3:12 ` Claude review: " Claude Code Review Bot
2026-03-06 15:55 [PATCH v36 0/4] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Jonathan Cavitt
2026-03-06 15:55 ` [PATCH v36 1/4] drm/xe/xe_pagefault: Disallow writes to read-only VMAs Jonathan Cavitt
2026-03-08 22:42 ` Claude review: " Claude Code Review Bot
2026-02-23 17:21 [PATCH v35 0/4] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Jonathan Cavitt
2026-02-23 17:21 ` [PATCH v35 1/4] drm/xe/xe_pagefault: Disallow writes to read-only VMAs Jonathan Cavitt
2026-02-24 0:00 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260324152935.72444-7-jonathan.cavitt@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox