From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/xe_pagefault: Disallow writes to read-only VMAs
Date: Wed, 25 Mar 2026 06:46:43 +1000
Message-ID: <review-patch1-20260324152935.72444-7-jonathan.cavitt@intel.com>
In-Reply-To: <20260324152935.72444-7-jonathan.cavitt@intel.com>
References: <20260324152935.72444-6-jonathan.cavitt@intel.com> <20260324152935.72444-7-jonathan.cavitt@intel.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Clean, straightforward bug fix. Has a `Reviewed-by` and `Fixes` tag.

```c
if (xe_vma_read_only(vma) &&
    pf->consumer.access_type != XE_PAGEFAULT_ACCESS_TYPE_READ) {
    err = -EPERM;
    goto unlock_vm;
}
```

This correctly catches both WRITE and ATOMIC access to read-only VMAs. The placement after the VMA lookup and before the atomic check is appropriate. No issues.

---
Generated by Claude Code Patch Reviewer