From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: backlight: ktd2801: enable BL_CORE_SUSPENDRESUME Date: Tue, 31 Mar 2026 17:51:56 +1000 Message-ID: In-Reply-To: <20260328-ktd2801-pm-fix-v1-1-007cb103faeb@dujemihanovic.xyz> References: <20260328-ktd2801-pm-fix-v1-1-007cb103faeb@dujemihanovic.xyz> <20260328-ktd2801-pm-fix-v1-1-007cb103faeb@dujemihanovic.xyz> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Good to merge** The change adds a single line to `ktd2801_backlight_ops`: ```c static const struct backlight_ops ktd2801_backlight_ops = { .options = BL_CORE_SUSPENDRESUME, .update_status = ktd2801_update_status, }; ``` This is the standard pattern used by many other backlight drivers (e.g., `pwm_bl`, `lp855x`, `gpio_backlight`, etc.) to have the backlight core handle suspend/resume automatically. When this flag is set, the core calls `backlight_suspend()` / `backlight_resume()` which sets `fb_blank` to `FB_BLANK_POWERDOWN` on suspend and restores it on resume, triggering `update_status`. The existing `ktd2801_update_status` already handles this correctly: - `backlight_is_blank()` returning true triggers `expresswire_power_off()` (line 40) - On resume, `expresswire_enable()` is called followed by the brightness write (lines 46-50) The `was_on` tracking (lines 41, 45-48) ensures the enable/disable sequencing is correct across suspend/resume cycles. The `Cc: stable@vger.kernel.org # v6.19` tag is appropriate since this is a bug fix for a driver introduced in that version. No issues found. --- Generated by Claude Code Patch Reviewer