From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: bridge: ldb: Require reg property only for i.MX6SX/8MP LDBs
Date: Tue, 31 Mar 2026 17:49:51 +1000
Message-ID: <review-patch1-20260329-fsl_ldb_schema_fix-v1-1-351372754bc0@nxp.com>
In-Reply-To: <20260329-fsl_ldb_schema_fix-v1-1-351372754bc0@nxp.com>
References: <20260329-fsl_ldb_schema_fix-v1-1-351372754bc0@nxp.com> <20260329-fsl_ldb_schema_fix-v1-1-351372754bc0@nxp.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Changes summary:**
1. Adds `minItems: 1` to the `reg` property definition
2. Removes `reg` from the global `required` list
3. Adds a new `if/then` block requiring `reg` only for `fsl,imx6sx-ldb` and=
 `fsl,imx8mp-ldb`
4. Restructures the `reg-names` conditional from a negated check ("not imx6=
sx") to a positive match ("only imx8mp")

**Analysis:**

The logic changes are correct:

- **Before:** `reg` required for all three variants (imx6sx, imx8mp, imx93)=
; `reg-names` required for imx8mp and imx93.
- **After:** `reg` required only for imx6sx and imx8mp; `reg-names` require=
d only for imx8mp.

This is consistent =E2=80=94 imx93 LDB needs neither `reg` nor `reg-names` =
since it lives under a syscon parent.

**Minor nits:**

1. `minItems: 1` on `reg` is technically redundant (1 is the implicit minim=
um for array properties in dt-schema), but it's harmless and clarifies inte=
nt alongside `maxItems: 2`. Not worth blocking over.

2. The commit message says "it's" (line 153 of the mbox) where it should be=
 "its":
```
LDB's parent device could be a syscon which doesn't allow a reg property
to be present in it's child devices
```
Should be `its child devices`.

3. The restructuring of the `reg-names` conditional is a nice cleanup. The =
old form:
```yaml
  - if:
      not:
        properties:
          compatible:
            contains:
              const: fsl,imx6sx-ldb
    then:
      required:
        - reg-names
```
used a negation that implicitly required `reg-names` for any future compati=
ble added to the schema. The new positive match:
```yaml
  - if:
      properties:
        compatible:
          contains:
            const: fsl,imx8mp-ldb
    then:
      required:
        - reg-names
```
is more explicit and safer for future compatible additions, which is the ri=
ght direction.

**Verdict:** Looks good. The Fixes tag is appropriate. Only the "it's =E2=
=86=92 its" typo in the commit message is worth mentioning to the author.

---
Generated by Claude Code Patch Reviewer