From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma/contiguous: Fix broken build Date: Tue, 31 Mar 2026 17:29:36 +1000 Message-ID: In-Reply-To: <20260330-dma-build-fix-v1-1-748b64f0d8af@kernel.org> References: <20260330-dma-build-fix-v1-1-748b64f0d8af@kernel.org> <20260330-dma-build-fix-v1-1-748b64f0d8af@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness:** The patch is correct. The default CMA region is already ha= ndled by `add_cma_heaps()` in `cma_heap.c` which calls `dev_get_cma_area(NU= LL)` to retrieve it, so the removed call in `dma_contiguous_reserve()` was = indeed redundant/dead: ```c - ret =3D dma_heap_cma_register_heap(dma_contiguous_default_area); - if (ret) - pr_warn("Couldn't register default CMA heap."); ``` The header deletion is appropriate =E2=80=94 after the parent commit remove= d the function definition, the header contained only a declaration with no = remaining users: ```c -int dma_heap_cma_register_heap(struct cma *cma); ``` **Completeness:** All include sites of `linux/dma-buf/heaps/cma.h` are cove= red (only `cma_heap.c` and `contiguous.c`). No other callers of `dma_heap_c= ma_register_heap()` remain after the parent commit. **Minor nit (commit message only):** The commit message says "the now unuse= d function definition" but the header file contains a function *declaration= * (and an inline stub for the `!CONFIG_DMABUF_HEAPS_CMA` case). The actual = function *definition* was in `cma_heap.c` and was presumably removed by the= parent commit. This is a cosmetic issue in the commit message and doesn't = affect the code. **Reviewed-by worthy:** Yes, this is a straightforward and correct build fi= x. --- Generated by Claude Code Patch Reviewer