From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vc4: Release runtime PM reference after binding V3D Date: Tue, 31 Mar 2026 17:01:59 +1000 Message-ID: In-Reply-To: <20260330-vc4-misc-fixes-v1-1-92defc940a29@igalia.com> References: <20260330-vc4-misc-fixes-v1-0-92defc940a29@igalia.com> <20260330-vc4-misc-fixes-v1-1-92defc940a29@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Good fix.** The `pm_runtime_resume_and_get()` at line 459 acquires a reference that is = only released on the error path (`err_put_runtime_pm`) but never on the suc= cess path. Adding `pm_runtime_put_autosuspend(dev)` after configuring autos= uspend is correct =E2=80=94 the device will remain active for the 40ms auto= suspend delay and then suspend if no other references are held. ```c pm_runtime_use_autosuspend(dev); pm_runtime_set_autosuspend_delay(dev, 40); /* a little over 2 frames. */ +pm_runtime_put_autosuspend(dev); ``` The placement after `pm_runtime_use_autosuspend()` and `pm_runtime_set_auto= suspend_delay()` is correct =E2=80=94 autosuspend must be configured before= calling `put_autosuspend`. Already has Melissa's Reviewed-by. No issues. --- --- Generated by Claude Code Patch Reviewer