From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/connector: Make drm_connector_attach_hdr_output_metadata_property() return void Date: Tue, 31 Mar 2026 17:13:28 +1000 Message-ID: In-Reply-To: <20260330133446.3265938-2-mcanal@igalia.com> References: <20260330133446.3265938-2-mcanal@igalia.com> <20260330133446.3265938-2-mcanal@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Reviewed-by worthy** =E2=80=94 clean and correct. The commit message accurately describes the change and the rationale. Two t= hings are done here: 1. **Return type change to void**: The function body just calls `drm_object= _attach_property()` (which is void) and then `return 0`. Removing the fake = return value is the right thing to do. Confirmed that none of the 6 callers= (amdgpu_dm, dw-hdmi, intel_dp =C3=972, intel_hdmi, meson_encoder_hdmi) che= ck the return value. 2. **Typo fix**: `"HDR_OUTPUT_METADA"` =E2=86=92 `"HDR_OUTPUT_METADATA"` in= the kerneldoc =E2=80=94 straightforward correction. The diff is minimal and correct: ```c -int drm_connector_attach_hdr_output_metadata_property(struct drm_connector= *connector) +void drm_connector_attach_hdr_output_metadata_property(struct drm_connecto= r *connector) ``` The removal of the `Returns:` section from the kerneldoc and the trailing b= lank line + `return 0` are appropriate. No concerns with this patch. --- Generated by Claude Code Patch Reviewer