From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: Add drm helper to check pr optimization support Date: Tue, 31 Mar 2026 17:12:01 +1000 Message-ID: In-Reply-To: <20260330133620.3750559-2-animesh.manna@intel.com> References: <20260330133620.3750559-1-animesh.manna@intel.com> <20260330133620.3750559-2-animesh.manna@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This adds a `pr_optimization_support` field to the tunnel struct, reads it = from `DP_TUNNELING_CAPABILITIES` DPCD register at tunnel creation, and expo= ses a query function. **Minor issue =E2=80=94 typo in kdoc:** ``` * Returns %true if the PR BW optimiation is supported for @tunnel. ``` "optimiation" =E2=86=92 "optimization" **Observation =E2=80=94 no update on hotplug/re-detect:** The `pr_optimizat= ion_support` flag is only set in `create_tunnel()`. Looking at `tunnel_info= _changes_are_valid()`, changes to `bw_alloc_supported` are detected and fla= gged, but there's no equivalent check for `pr_optimization_support`. This i= s probably fine in practice since the tunneling capabilities register is un= likely to change at runtime without a full disconnect/reconnect (which woul= d destroy and recreate the tunnel), but it's worth noting for consistency. = Not a blocker. **The stub for `CONFIG_DRM_DISPLAY_DP_TUNNEL=3Dn` is correct** =E2=80=94 re= turns false. --- Generated by Claude Code Patch Reviewer