From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: rz-du: Ensure correct suspend/resume ordering with VSP Date: Tue, 31 Mar 2026 17:10:17 +1000 Message-ID: In-Reply-To: <20260330144651.817338-1-tommaso.merciai.xr@bp.renesas.com> References: <20260330144651.817338-1-tommaso.merciai.xr@bp.renesas.com> <20260330144651.817338-1-tommaso.merciai.xr@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Commit message:** Clear and well-written. Explains *why* the device link = is needed (suspend/resume ordering), credits the original R-Car DU work, an= d includes the reference commit hash. **Header changes (`rzg2l_du_vsp.h`):** - Forward declaration of `struct device_link` added in correct alphabetical= position. - New `struct device_link *link` member added to `struct rzg2l_du_vsp` =E2= =80=94 correct placement alongside the existing `struct device *vsp`. **Init path (`rzg2l_du_vsp_init`):** ```c vsp->link =3D device_link_add(rcdu->dev, vsp->vsp, DL_FLAG_STATELESS); ``` - `rcdu->dev` (DU) is correctly the consumer, `vsp->vsp` is correctly the s= upplier. - `DL_FLAG_STATELESS` is the right flag =E2=80=94 it enforces suspend/resum= e ordering without managing the device lifecycle. This matches the R-Car DU= driver. - Error path returns `-EINVAL` with a dev_err message =E2=80=94 appropriate. - Placement after `drmm_add_action_or_reset()` and before `vsp1_du_init()` = is correct: the cleanup action is already registered, so if `device_link_ad= d` or `vsp1_du_init` fails, `rzg2l_du_vsp_cleanup` will be called and will = properly delete the link (or skip if NULL). **Cleanup path (`rzg2l_du_vsp_cleanup`):** ```c if (vsp->link) device_link_del(vsp->link); ``` - The NULL check is correct for the case where `device_link_add` failed (si= nce cleanup is registered before the link is created). - `device_link_del` before `put_device` is the right ordering. **Include addition:** `` added in alphabetical order =E2=80= =94 correct. **No issues.** The patch is a clean, minimal, well-motivated change that mi= rrors proven code from the R-Car DU driver. --- Generated by Claude Code Patch Reviewer