Claude review: accel/amdxdna: Create common PSP interfaces for AIE2 and AIE4

Claude Code Review Bot
2026-03-31T07:05:09Z

Patch Review

Renames `aie2_psp.c` → `aie_psp.c` and moves PSP types/declarations into `aie.h`.

**Issue 1 — Copyright year change removes history:**
```c
-// Copyright (C) 2022-2024, Advanced Micro Devices, Inc.
+// Copyright (C) 2026, Advanced Micro Devices, Inc.
```
The original copyright range (2022-2024) is replaced with just 2026. This loses the attribution history. Should be `2022-2026`.

**Issue 2 — `psp_conf` zero-initialization:**
```c
- struct psp_config psp_conf;
+ struct psp_config psp_conf = { 0 };
```
Good — needed because `psp_config` now has more fields (`certfw_buf`, `certfw_size`, `arg2_mask`, `notify_val`). But `arg2_mask` and `notify_val` are not set in this patch (they're added in patch 4), so `arg2_mask = 0` and `notify_val = 0` would be used if PSP runs before patch 4 is applied. This means the series has a bisection issue — patches 3 alone would break PSP because `notify_val = 0` means the interrupt never fires.

---
Generated by Claude Code Patch Reviewer