From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: lcdif: Set undocumented bit to clear FIFO at vsync Date: Tue, 31 Mar 2026 16:48:35 +1000 Message-ID: In-Reply-To: <20260330224619.2620782-2-paulk@sys-base.io> References: <20260330224619.2620782-1-paulk@sys-base.io> <20260330224619.2620782-2-paulk@sys-base.io> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Looks reasonable.** BIT(23) sits directly above `P_SIZE` at GENMASK(22,20), so there's no bit overlap. Minor nit: the commit message says "it doesn't hurt to add it as an extra safety measure," which is a weak justification for setting an undocumented bit in a register. It would be better to reference the specific NXP BSP commit or file where this bit is used, so future readers can cross-reference. For an undocumented bit, any available context on what it actually does would strengthen the patch. No functional issues. --- --- Generated by Claude Code Patch Reviewer