Claude review: drm/panel: simple: add Waveshare LCD panels

Claude Code Review Bot
2026-03-31T21:39:19Z

Overall Series Review

Subject: drm/panel: simple: add Waveshare LCD panels
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 5
Reviewed: 2026-04-01T07:39:19.359525

---

This is a well-structured, straightforward series by Dmitry Baryshkov adding support for additional Waveshare DSI LCD panel kits. The series is logically organized: bindings first (patches 1 and 3), then driver support (patches 2 and 4). The technical approach is sound -- reusing the existing waveshare-dsi bridge driver with a new compatible for LVDS variants, and adding panel timing definitions in panel-simple.c.

The series has one notable issue: **missing trailing commas** in the OF match table entries in patch 4. There is also a forward declaration of `waveshare_80_lcd_c_mode` that, while functional, could be avoided by reordering the definitions. Overall this looks ready with minor style fixes.