From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: misc: qcom, fastrpc: Add compatible for Glymur
Date: Tue, 31 Mar 2026 16:45:30 +1000
Message-ID: <review-patch1-20260331032121.1279203-1-sibi.sankar@oss.qualcomm.com>
In-Reply-To: <20260331032121.1279203-1-sibi.sankar@oss.qualcomm.com>
References: <20260331032121.1279203-1-sibi.sankar@oss.qualcomm.com> <20260331032121.1279203-1-sibi.sankar@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**The change:** Converts the `compatible` property schema from a flat `enum=
` to a `oneOf` with two alternatives:
1. The original enum (`qcom,kaanapali-fastrpc`, `qcom,fastrpc`)
2. A new fallback pattern: `qcom,glymur-fastrpc`, `qcom,kaanapali-fastrpc`

This correctly models that Glymur fastrpc is fully compatible with Kaanapal=
i fastrpc, using the standard DT idiom of `<soc-specific>, <fallback>`.

**Minor observations:**

- The YAML schema change is correct. Using `oneOf` with a separate `items` =
block for the fallback compatible pair is the standard pattern in dt-bindin=
gs.

- The `items` block with a single-entry `enum` (lines 205-206):
  ```yaml
        - items:
            - enum:
                - qcom,glymur-fastrpc
            - const: qcom,kaanapali-fastrpc
  ```
  Using `enum` with a single entry works but `const: qcom,glymur-fastrpc` w=
ould be slightly more concise (matching the style used for the kaanapali fa=
llback on the next line). This is a stylistic nit =E2=80=94 using `enum` is=
 also acceptable and is the preferred pattern in many bindings since it mak=
es future additions easier without restructuring.

- The commit message is clear and the changelog is thorough.

- Has Reviewed-by from Krzysztof Kozlowski (Qualcomm DT maintainer).

**Verdict:** No issues. Patch is ready to merge.

---
Generated by Claude Code Patch Reviewer