From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: verisilicon: make vs_format conversion function return int Date: Tue, 31 Mar 2026 16:44:29 +1000 Message-ID: In-Reply-To: <20260331060126.1291966-2-zhengxingda@iscas.ac.cn> References: <20260331060126.1291966-1-zhengxingda@iscas.ac.cn> <20260331060126.1291966-2-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good** Clean mechanical change. Converts `drm_format_to_vs_format()` from `void` t= o `int`, replacing the `pr_warn()` on unknown format with `return -EINVAL`,= and adding `return 0` on the success path. The commit message correctly no= tes the return value is not yet checked =E2=80=94 that comes in patch 4. The `pr_warn()` removal is fine since callers will now check the return cod= e. No issues. --- Generated by Claude Code Patch Reviewer