From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dpu: eliza: Use Eliza-specific CWB array Date: Wed, 01 Apr 2026 07:37:07 +1000 Message-ID: In-Reply-To: <20260331161156.211623-2-krzysztof.kozlowski@oss.qualcomm.com> References: <20260331161156.211623-2-krzysztof.kozlowski@oss.qualcomm.com> <20260331161156.211623-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Looks good.** The fix is a one-line change that's obviously correct: ```c .cwb_count =3D ARRAY_SIZE(eliza_cwb), -.cwb =3D sm8650_cwb, +.cwb =3D eliza_cwb, ``` The `.cwb_count` already counted `eliza_cwb`, so `.cwb` must point to the s= ame array. The Fixes tag and commit message are clear. **Minor nit:** The commit message says "different register space sizes" =E2= =80=94 it might be worth noting in the message *what* actually differs betw= een `eliza_cwb` and `sm8650_cwb` (e.g., different `len` values in the CWB b= lock definitions), but this is not a blocker. **Suggestion:** Consider also fixing the same pattern in `sm8750`, `glymur`= , and `kaanapali` catalog headers, which appear to have the identical `.cwb= =3D sm8650_cwb` copy-paste issue in the current drm-next tree. Reviewed-by worthy as-is. --- Generated by Claude Code Patch Reviewer