From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: require little endian Date: Sun, 12 Apr 2026 14:47:45 +1000 Message-ID: In-Reply-To: <20260406-fix-kconfig-v1-1-8f634499f7f0@nvidia.com> References: <20260406-fix-kconfig-v1-1-8f634499f7f0@nvidia.com> <20260406-fix-kconfig-v1-1-8f634499f7f0@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Looks good.** The one-line diff is straightforward: ``` depends on 64BIT depends on PCI depends on RUST + depends on !CPU_BIG_ENDIAN select AUXILIARY_BUS ``` **Observations:** 1. **Placement is correct.** The new `depends on` line is placed after the = existing `depends on` lines and before the `select` lines, following standa= rd Kconfig ordering conventions. 2. **The LE assumption is real.** The driver uses `FromBytes` (which does n= ative-endian reinterpretation of byte slices) on several packed structs in = `vbios.rs:332,392,550,854`. It also uses explicit `u32::from_le_bytes()` / = `u16::from_le_bytes()` in `falcon.rs:432,461` and `vbios.rs:445,449,490,502= ,510,515,795,840`. The mixture of explicit LE conversion and raw byte reint= erpretation confirms that the driver would not work correctly on a big-endi= an system =E2=80=94 some data would be byte-swapped and some wouldn't. 3. **The commit message's RUST claim is slightly imprecise.** The message s= ays "RUST transitively depends on !CPU_BIG_ENDIAN" =E2=80=94 this isn't str= ictly true via Kconfig dependency chains. What is true is that on arm64 (th= e only 64-bit arch where `CPU_BIG_ENDIAN` exists), `CPU_BIG_ENDIAN` current= ly `depends on BROKEN`, making it impossible to select in practice. The pat= ch is still valuable because it makes the requirement explicit rather than = relying on an indirect and potentially fragile transitive constraint. The b= elow-the-cut explanation acknowledges this nuance, which is good. 4. **Minor nit on the commit message:** The phrase "all the code that reads= RPCs out of the command queue just directly interprets the bytes" could be= more precise =E2=80=94 the vbios parsing code with `FromBytes` is arguably= a better example of implicit LE assumptions than the RPC code. No blocking issues. The patch is a single-line, obviously-correct Kconfig d= ependency addition. --- Generated by Claude Code Patch Reviewer