Claude review: gpu: nova-core: require little endian

Claude Code Review Bot
2026-04-12T04:47:44Z

Overall Series Review

Subject: gpu: nova-core: require little endian
Author: Eliot Courtney <ecourtney@nvidia.com>
Patches: 9
Reviewed: 2026-04-12T14:47:44.840568

---

This is a single-patch series adding `depends on !CPU_BIG_ENDIAN` to the nova-core Kconfig. The change is **correct in intent and low-risk**. The nova-core driver does assume little-endian byte order in multiple places — both via explicit `from_le_bytes()` calls (in `falcon.rs`, `vbios.rs`) and, more critically, via `FromBytes` / `from_bytes_copy_prefix()` patterns that reinterpret raw byte slices as structs without any endianness conversion (e.g., `PcirStruct`, `BitHeader`, `NpdeStruct`, `PmuLookupTableHeader` in `vbios.rs`). The GSP firmware command queue code also directly interprets byte buffers.

The commit message's claim that "RUST transitively depends on !CPU_BIG_ENDIAN" is practically true today but slightly imprecise — on arm64, `CPU_BIG_ENDIAN` depends on `BROKEN`, so it can't actually be selected, but it's not a hard Kconfig dependency of `RUST` itself. This makes the patch more of a "belt and suspenders" measure, which is fine — it makes the requirement explicit and future-proof in case the arm64 big-endian situation ever changes.

The patch is simple, correct, and harmless. **Recommend accepting.**

---

---
Generated by Claude Code Patch Reviewer