From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imx: Fix three kernel-doc warnings in dcss-scaler.c
Date: Sun, 12 Apr 2026 14:25:41 +1000
Message-ID: <review-patch1-20260406180013.2442096-1-yiconghui@gmail.com>
In-Reply-To: <20260406180013.2442096-1-yiconghui@gmail.com>
References: <20260406180013.2442096-1-yiconghui@gmail.com> <20260406180013.2442096-1-yiconghui@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Looks good**

The patch adds three missing `@param` entries to kernel-doc comments:

1. `@phase0_identity` in `dcss_scaler_gaussian_filter()` (line 169) =E2=80=
=94 description "whether to override phase 0 coefficients with identity fil=
ter" accurately matches the usage at line 227:
   ```c
   /* override phase 0 with identity filter if specified */
   if (phase0_identity)
       for (i =3D 0; i < PSC_NUM_TAPS; i++)
           coef[0][i] =3D i =3D=3D (PSC_NUM_TAPS >> 1) ?
                       (1 << PSC_COEFF_PRECISION) : 0;
   ```

2. `@phase0_identity` in `dcss_scaler_filter_design()` (line 266) =E2=80=94=
 same description, parameter is passed through to `dcss_scaler_gaussian_fil=
ter()`. Accurate.

3. `@nn_interpolation` in `dcss_scaler_filter_design()` (line 268) =E2=80=
=94 description "whether to use nearest neighbor instead of gaussian filter=
" accurately matches the usage at line 283:
   ```c
   if (nn_interpolation)
       dcss_scaler_nearest_neighbor_filter(use_5_taps, coef);
   else
       dcss_scaler_gaussian_filter(fc_q, use_5_taps, phase0_identity, coef);
   ```

**Minor nit (non-blocking):** In `dcss_scaler_filter_design()`, the `@coef`=
 and `@nn_interpolation` doc entries are ordered as `@coef` then `@nn_inter=
polation`, but the function signature has `coef` before `nn_interpolation` =
too =E2=80=94 so the ordering is correct. Good.

**On the Fixes tag:** The `Fixes:` tag pointing to the original commit `902=
1c317b770` ("drm/imx: Add initial support for DCSS on iMX8MQ") is technical=
ly correct since that's where the undocumented parameters were introduced, =
though using `Fixes:` for a kernel-doc-only change is debatable =E2=80=94 t=
his isn't fixing a functional bug. It's common practice either way, so this=
 is just a style observation.

**Verdict:** Patch is correct and ready to apply. The descriptions are accu=
rate, the parameter order in the doc comments matches the function signatur=
es, and the three W=3D1 warnings will be resolved.

---
Generated by Claude Code Patch Reviewer