From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova: require little endian Date: Sun, 12 Apr 2026 14:07:45 +1000 Message-ID: In-Reply-To: <20260407-fix-kconfig-v2-1-6b4fb06c690c@nvidia.com> References: <20260407-fix-kconfig-v2-1-6b4fb06c690c@nvidia.com> <20260407-fix-kconfig-v2-1-6b4fb06c690c@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Change:** Adds `depends on !CPU_BIG_ENDIAN` to both `drivers/gpu/drm/nova/Kconfig` and `drivers/gpu/nova-core/Kconfig`, placed after `depends on RUST` in each file. **Analysis:** 1. **Correctness:** The placement is appropriate -- it follows the existing `depends on` block and comes before the `select` directives, which is consistent with Kconfig style conventions. 2. **Ordering within Kconfig:** Looking at the current tree files, the drm-next tree has slightly different ordering from the patch's context. The current `DRM_NOVA` starts with: ``` depends on 64BIT depends on DRM=y depends on PCI depends on RUST ``` while the patch's context shows: ``` depends on DRM=y depends on PCI depends on RUST ``` (missing `depends on 64BIT`). This explains why the patches didn't apply cleanly -- the base differs from drm-next. This is a rebase issue, not a patch correctness issue; the base commit `a7a080bb4236` is likely from a different tree. Not a concern for review. 3. **Scope:** Adding the dependency to both `nova-core` and `nova-drm` is correct. Since `DRM_NOVA` selects `NOVA_CORE`, the dependency on `nova-core` alone might seem sufficient, but `select` bypasses dependency checks, so having it explicit on both entries prevents broken configurations. 4. **Commit message:** Clear and well-reasoned. The cover letter discussion about making the endianness decision explicit rather than having "some handling sprinkled around" is a sensible engineering argument. 5. **v1 to v2 delta:** The author correctly dropped the v1 Reviewed-by/Acked-by tags since the patch changed substantively (adding `nova-drm` in addition to `nova-core`). No issues. The patch is ready to merge (with a trivial rebase onto the appropriate base). --- Generated by Claude Code Patch Reviewer